[EXT] Re: [PATCH] net: stmmac: dwmac-imx: pause the TXC clock in fixed-link

[Shenwei Wang]

> -----Original Message-----
> From: Russell King <linux at armlinux.org.uk>
> Sent: Wednesday, July 26, 2023 2:02 PM
> To: Shenwei Wang <shenwei.wang at nxp.com>
> Cc: Vladimir Oltean <olteanv at gmail.com>; David S. Miller
> <davem at davemloft.net>; Eric Dumazet <edumazet at google.com>; Jakub
> Kicinski <kuba at kernel.org>; Paolo Abeni <pabeni at redhat.com>; Maxime
> Coquelin <mcoquelin.stm32 at gmail.com>; Shawn Guo <shawnguo at kernel.org>;
> dl-linux-imx <linux-imx at nxp.com>; Giuseppe Cavallaro
> <peppe.cavallaro at st.com>; Alexandre Torgue <alexandre.torgue at foss.st.com>;
> Jose Abreu <joabreu at synopsys.com>; Sascha Hauer <s.hauer at pengutronix.de>;
> Pengutronix Kernel Team <kernel at pengutronix.de>; Fabio Estevam
> <festevam at gmail.com>; netdev at vger.kernel.org; linux-stm32 at st-md-
> mailman.stormreply.com; linux-arm-kernel at lists.infradead.org;
> imx at lists.linux.dev; Frank Li <frank.li at nxp.com>
> Subject: Re: [EXT] Re: [PATCH] net: stmmac: dwmac-imx: pause the TXC clock in
> fixed-link
> >
> > Then, the way this phylink driver behaves makes the rest of the
> > discussion kind of pointless for now, because I don't actually need
> fix_mac_speed to give me any interface info now.
> > The basic of_phy_is_fixed_link check does the job for me.
> >
> > Not sure why you think it's inefficient - could you explain that part?
>
> Because of_phy_is_fixed_link() has to chase various pointers, walk the child
> nodes and do a string compare on each, whereas you could just be testing an
> integer!
>

I don't think It's worth the effort to change the definition of fix_mac_speed across all platforms,
because the function is only called once when the interface is up.

Thanks,
Shenwei

> --
> RMK's Patch system:
> https://www.ar/
> mlinux.org.uk%2Fdeveloper%2Fpatches%2F&data=05%7C01%7Cshenwei.wang
> %40nxp.com%7C682cfc4392cc4e4b539508db8e0ae172%7C686ea1d3bc2b4c6fa
> 92cd99c5c301635%7C0%7C0%7C638259949620016392%7CUnknown%7CTWFp
> bGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6
> Mn0%3D%7C3000%7C%7C%7C&sdata=sJy6gzd1LBe%2Bikz1lL3Pq4fK30ehMY%2
> BJKQMJbkOFp4I%3D&reserved=0
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!