[PATCH v5] i2c: imx-lpi2c: return -EINVAL when i2c peripheral clk doesn't work

Andi Shyti andi.shyti at kernel.org
Wed Jul 26 07:58:23 PDT 2023


Hi Carlos,

On Wed, Jul 26, 2023 at 05:22:38PM +0800, carlos.song at nxp.com wrote:
> From: Carlos Song <carlos.song at nxp.com>
> 
> On MX8X platforms, the default clock rate is 0 if without explicit
> clock setting in dts nodes. I2c can't work when i2c peripheral clk
> rate is 0.
> 
> Add a i2c peripheral clk rate check before configuring the clock
> register. When i2c peripheral clk rate is 0 and directly return
> -EINVAL.
> 
> Signed-off-by: Carlos Song <carlos.song at nxp.com>

you are missing here:

Acked-by: Dong Aisheng <Aisheng.dong at nxp.com>

You can also add:

Reviewed-by: Andi Shyti <andi.shyti at kernel.org> 

(no need to resend)

Thanks!
Andi



More information about the linux-arm-kernel mailing list