[PATCH v5 4/6] arm64: dts: qcom: ipq5332: Add USB related nodes
Bjorn Andersson
andersson at kernel.org
Fri Jul 21 22:05:34 PDT 2023
On Fri, Jul 21, 2023 at 10:05:29AM +0530, Varadarajan Narayanan wrote:
> diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> index 8bfc2db..a22f340 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> @@ -405,6 +405,62 @@
> status = "disabled";
> };
> };
> +
> + usbphy0: usb-phy at 7b000 {
s/usb-phy/phy/
> + compatible = "qcom,ipq5332-usb-hsphy";
> + reg = <0x0007b000 0x12c>;
Sort your nodes under /soc by their address.
> +
> + clocks = <&gcc GCC_USB0_PHY_CFG_AHB_CLK>;
> + clock-names = "cfg_ahb";
> +
> + resets = <&gcc GCC_QUSB2_0_PHY_BCR>;
> +
> + #phy-cells = <0>;
> +
> + status = "disabled";
> + };
> +
> + usb2: usb2 at 8a00000 {
usb at ... drop the '2' in the node name (not in the label). Although, why
does usb2 use the phy labeled usb0?
Regards,
Bjorn
More information about the linux-arm-kernel
mailing list