[Enable Designware XGMAC VLAN Stripping Feature 1/2] dt-bindings: net: snps,dwmac: Add description for rx-vlan-offload

Ng, Boon Khai boon.khai.ng at intel.com
Fri Jul 21 09:39:10 PDT 2023


> -----Original Message-----
> From: Krzysztof Kozlowski <krzk at kernel.org>
> Sent: Saturday, July 22, 2023 12:26 AM
> To: Ng, Boon Khai <boon.khai.ng at intel.com>; Boon at ecsmtp.png.intel.com;
> Khai at ecsmtp.png.intel.com; Giuseppe Cavallaro <peppe.cavallaro at st.com>;
> Alexandre Torgue <alexandre.torgue at foss.st.com>; Jose Abreu
> <joabreu at synopsys.com>; David S . Miller <davem at davemloft.net>; Eric
> Dumazet <edumazet at google.com>; Jakub Kicinski <kuba at kernel.org>;
> Paolo Abeni <pabeni at redhat.com>; Maxime Coquelin
> <mcoquelin.stm32 at gmail.com>; netdev at vger.kernel.org; linux-stm32 at st-
> md-mailman.stormreply.com; linux-arm-kernel at lists.infradead.org; linux-
> kernel at vger.kernel.org
> Cc: Shevchenko, Andriy <andriy.shevchenko at intel.com>; Tham, Mun Yew
> <mun.yew.tham at intel.com>; Swee, Leong Ching
> <leong.ching.swee at intel.com>; G Thomas, Rohan
> <rohan.g.thomas at intel.com>; Shevchenko Andriy
> <andriy.shevchenko at linux.intel.com>
> Subject: Re: [Enable Designware XGMAC VLAN Stripping Feature 1/2] dt-
> bindings: net: snps,dwmac: Add description for rx-vlan-offload
> 
> On 21/07/2023 17:28, Ng, Boon Khai wrote:
> > This is a new device bringup, thus the DT is not available yet. The
> > DTS will be upstreamed by my another colleague, unless, if I can upstream
> only my part on the setting?
> >
> >> Please kindly resend and include all necessary To/Cc entries.
> 
> To be clear, since you do not agree with my comment you skipped vital lists,
> this was not tested by automation so it is NAK from me.
> 
> Sorry.
> 

I understand that I already get a NAK at the beginning. But I don’t understand why,
Please don’t get me wrong, I'm not disagreeing your comments, was trying to understand
the reason behind and also which are the step that I made a mistake(s) on,  this is to help
me to learn at the same time to smoothen the upstreaming process.

> Best regards,
> Krzysztof



More information about the linux-arm-kernel mailing list