[PATCH v6 02/11] drm/mediatek: dp: Move AUX and panel poweron/off sequence to function
Alexandre Mergnat
amergnat at baylibre.com
Thu Jul 20 08:56:48 PDT 2023
Reviewed-by: Alexandre Mergnat <amergnat at baylibre.com>
On 17/07/2023 16:14, AngeloGioacchino Del Regno wrote:
> Everytime we run bridge detection and/or EDID read we run a poweron
> and poweroff sequence for both the AUX and the panel; moreover, this
> is also done when enabling the bridge in the .atomic_enable() callback.
>
> Move this power on/off sequence to a new mtk_dp_aux_panel_poweron()
> function as to commonize it.
> Note that, before this commit, in mtk_dp_bridge_atomic_enable() only
> the AUX was getting powered on but the panel was left powered off if
> the DP cable wasn't plugged in while now we unconditionally send a D0
> request and this is done for two reasons:
> - First, whether this request fails or not, it takes the same time
> and anyway the DP hardware won't produce any error (or, if it
> does, it's ignorable because it won't block further commands)
> - Second, training the link between a sleeping/standby/unpowered
> display makes little sense.
--
Regards,
Alexandre
More information about the linux-arm-kernel
mailing list