[PATCH 1/3] arm: Fix flush_dcache_page() for usage from irq context

Helge Deller deller at gmx.de
Wed Jul 19 23:53:37 PDT 2023


On 5/24/23 22:00, Arnd Bergmann wrote:
> On Wed, May 24, 2023, at 17:26, Helge Deller wrote:
>> Since at least kernel 6.1, flush_dcache_page() is called with IRQs
>> disabled, e.g. from aio_complete().
>>
>> But the current implementation for flush_dcache_page() on ARM
>> unintentionally re-enables IRQs, which may lead to deadlocks.
>>
>> Fix it by using xa_lock_irqsave() and xa_unlock_irqrestore()
>> for the flush_dcache_mmap_*lock() macros instead.
>>
>> Cc: Russell King (Oracle) <linux at armlinux.org.uk>
>> Cc: Arnd Bergmann <arnd at arndb.de>
>> Cc: linux-arm-kernel at lists.infradead.org
>> Signed-off-by: Helge Deller <deller at gmx.de>
>
> Cc: stable at vger.kernel.org
> Reviewed-by: Arnd Bergmann <arnd at arndb.de>
>
>  From what I can tell, the behavior in aio_complete has been
> there for over 10 years, since 21b40200cfe96 ("aio: use
> flush_dcache_page()"). Others may have done the same already
> back then.

gentle ping...
I think this patch hasn't been picked up yet for arm.

Helge



More information about the linux-arm-kernel mailing list