[PATCH net-next] page_pool: split types and declarations from page_pool.h

Alexander Lobakin aleksander.lobakin at intel.com
Wed Jul 19 09:42:17 PDT 2023


From: Yunsheng Lin <linyunsheng at huawei.com>
Date: Wed, 19 Jul 2023 20:13:37 +0800

> Split types and pure function declarations from page_pool.h
> and add them in page_page_types.h, so that C sources can
> include page_pool.h and headers should generally only include
> page_pool_types.h as suggested by jakub.
> 
> Signed-off-by: Yunsheng Lin <linyunsheng at huawei.com>
> Suggested-by: Jakub Kicinski <kuba at kernel.org>
> CC: Alexander Lobakin <aleksander.lobakin at intel.com>
Nice!

Let me take it into my tree, I assume it's safe to say it will be
accepted sooner than my patches :D

BTW, what do you think: is it better to have those two includes in the
root include/net/ folder or do something like

include/net/page_pool/
  * types.h
  * <some meaningful name>.h (let's say driver.h)

like it's done e.g. for GPIO (see include/linux/gpio/)?

Thanks,
Olek



More information about the linux-arm-kernel mailing list