[PATCH 3/3] arm64: dts: Add node for chip info driver

Krzysztof Kozlowski krzysztof.kozlowski at linaro.org
Tue Jul 18 04:51:40 PDT 2023


On 18/07/2023 13:21, William-tw Lin wrote:
> Add dts node for socinfo retrieval. This includes the following projects:
> MT8173
> MT8183
> MT8186
> MT8192
> MT8195

Please
wrap
your
lines. :)

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.

Anyway, your commit suggests even more that you add driver. Drivers do
not have place in DTS nor in bindings. Your code in patch 2 is very poor
quality, so considering this "driver approach" I think you just send
some random downstream driver. Don't.

Entire concept is NAK.



Best regards,
Krzysztof




More information about the linux-arm-kernel mailing list