[PATCH] arm64: Explicitly include correct DT includes

Will Deacon will at kernel.org
Mon Jul 17 02:06:01 PDT 2023


On Fri, Jul 14, 2023 at 11:40:20AM -0600, Rob Herring wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
> 
> Signed-off-by: Rob Herring <robh at kernel.org>
> ---
>  arch/arm64/kernel/cpuidle.c | 2 --
>  arch/arm64/kernel/pci.c     | 2 --
>  2 files changed, 4 deletions(-)
> 
> diff --git a/arch/arm64/kernel/cpuidle.c b/arch/arm64/kernel/cpuidle.c
> index d1f68599c29f..f372295207fb 100644
> --- a/arch/arm64/kernel/cpuidle.c
> +++ b/arch/arm64/kernel/cpuidle.c
> @@ -9,8 +9,6 @@
>  #include <linux/acpi.h>
>  #include <linux/cpuidle.h>
>  #include <linux/cpu_pm.h>
> -#include <linux/of.h>
> -#include <linux/of_device.h>
>  #include <linux/psci.h>

I don't grok how dropping 'linux/of.h' follows from the commit message.
Is it simply not needed by this file?

Will



More information about the linux-arm-kernel mailing list