[PATCH] selftests: Fix arm64 test installation

Shuah Khan skhan at linuxfoundation.org
Fri Jul 14 10:48:51 PDT 2023


On 7/13/23 14:16, John Hubbard wrote:
> On 7/13/23 13:02, Shuah Khan wrote:
>> On 7/10/23 08:04, Mark Brown wrote:
> ...
>>> -kernel_header_files:
>>> -    @ls $(KHDR_DIR)/linux/*.h >/dev/null 2>/dev/null;                      \
>>> -    if [ $$? -ne 0 ]; then                                                 \
>>> -            RED='\033[1;31m';                                                  \
>>> -            NOCOLOR='\033[0m';                                                 \
>>> -            echo;                                                              \
>>> -            echo -e "$${RED}error$${NOCOLOR}: missing kernel header files.";   \
>>> -            echo "Please run this and try again:";                             \
>>> -            echo;                                                              \
>>> -            echo "    cd $(top_srcdir)";                                       \
>>> -            echo "    make headers";                                           \
>>> -            echo;                                                              \
>>> -        exit 1; \
>>> -    fi
>>> -
>>> -.PHONY: kernel_header_files
>>> +all: $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES)
>>>   define RUN_TESTS
>>>       BASE_DIR="$(selfdir)";            \
>>>
>>> ---
>>> base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5
>>> change-id: 20230710-kselftest-fix-arm64-c023160018d7
>>>
>>> Best regards,
>>
>> Thank you. Will apply the patch for the next rc
>>
>> thanks,
>> -- Shuah
> 
> Hi Shuah,
> 
> Actually, I was hoping that my two fixes [1], [2] could be used, instead
> of reverting the feature.
> 
> 
> [1] https://lore.kernel.org/all/20230711005629.2547838-1-jhubbard@nvidia.com/
> 
> [2] https://lore.kernel.org/all/20230712193514.740033-1-jhubbard@nvidia.com/
> 
> 

Thanks - I will go do that now.

Mark! Are you good with taking these two - do these fix the
problems you are seeing?

thanks,
-- Shuah




More information about the linux-arm-kernel mailing list