[PATCH 3/3] arm64: dts: freescale: Add DEBIX SOM A and SOM A I/O Board support
Marco Felsch
m.felsch at pengutronix.de
Fri Jul 14 07:38:26 PDT 2023
Hi Fabio,
On 23-07-04, Fabio Estevam wrote:
> Hi Marco,
>
> On Tue, Jul 4, 2023 at 3:41 PM Marco Felsch <m.felsch at pengutronix.de> wrote:
>
> > +&fec {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_fec>;
> > + phy-mode = "rgmii-id";
> > + phy-handle = <ðphy1>;
> > + fsl,magic-packet;
> > + phy-reset-gpios = <&gpio4 19 GPIO_ACTIVE_LOW>;
> > + phy-reset-duration = <10>;
> > + phy-reset-post-delay = <150>;
>
> These properties are deprecated. Please move them under the mdio node.
right
> > + /*
> > + * Since USB1 is binded to peripheral mode we need to ensure
>
> s/binded/bound
sure
> > +/* µSD Card */
> > +&usdhc2 {
> > + pinctrl-names = "default", "state_100mhz", "state_200mhz";
> > + pinctrl-0 = <&pinctrl_usdhc2>;
> > + pinctrl-1 = <&pinctrl_usdhc2_100mhz>;
> > + pinctrl-2 = <&pinctrl_usdhc2_200mhz>;
> > + vmmc-supply = <®_usdhc2_vmmc>;
> > + bus-width = <4>;
> > + disable-wp;
> > + no-sdio;
> > + no-mmc;
> > +
>
> No need for this blank line.
I added the blank lines for a better separation, but I can drop these.
> > + assigned-clocks = <&clk IMX8MP_CLK_USDHC2>;
> > + assigned-clock-rates = <400000000>;
> > +
>
> Ditto.
>
> > +
> > + pmic at 25 {
> > + compatible = "nxp,pca9450c";
> > + reg = <0x25>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_pmic>;
> > +
> > + interrupt-parent = <&gpio1>;
> > + interrupts = <3 GPIO_ACTIVE_LOW>;
> > +
> > + regulators {
> > + buck1: BUCK1 {
> > + regulator-name = "BUCK1";
> > + regulator-min-microvolt = <600000>;
> > + regulator-max-microvolt = <2187500>;
> > + regulator-boot-on;
> > + regulator-always-on;
> > + regulator-ramp-delay = <3125>;
> > + };
> > +
> > + buck2: BUCK2 {
> > + regulator-name = "BUCK2";
> > + regulator-min-microvolt = <600000>;
> > + regulator-max-microvolt = <2187500>;
> > + regulator-boot-on;
> > + regulator-always-on;
> > + regulator-ramp-delay = <3125>;
> > + nxp,dvs-run-voltage = <950000>;
> > + nxp,dvs-standby-voltage = <850000>;
> > + };
> > +
> > + buck4: BUCK4{
>
> Missing space after BUCK4.
yes.
> > + regulator-name = "BUCK4";
> > + regulator-min-microvolt = <600000>;
> > + regulator-max-microvolt = <3400000>;
> > + regulator-boot-on;
> > + regulator-always-on;
> > + };
> > +
> > + buck5: BUCK5{
>
> Ditto.
yes.
> > +&usdhc3 {
> > + pinctrl-names = "default", "state_100mhz", "state_200mhz";
> > + pinctrl-0 = <&pinctrl_usdhc3>;
> > + pinctrl-1 = <&pinctrl_usdhc3_100mhz>;
> > + pinctrl-2 = <&pinctrl_usdhc3_200mhz>;
> > + bus-width = <8>;
> > + non-removable;
> > +
>
> No need for this blank line.
>
>
> > + assigned-clocks = <&clk IMX8MP_CLK_USDHC3>;
> > + assigned-clock-rates = <400000000>;
> > +
>
> Ditto.
Removed these as well. Thanks for your review :)
Regards,
Marco
More information about the linux-arm-kernel
mailing list