[PATCH 58/58] mmc: Convert to platform remove callback returning void

Florian Fainelli florian.fainelli at broadcom.com
Fri Jul 14 03:12:54 PDT 2023



On 7/13/2023 10:08 AM, Yangtao Li wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Cc: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> Signed-off-by: Yangtao Li <frank.li at vivo.com>
> ---
>   drivers/mmc/host/sdhci-bcm-kona.c  | 2 +-
>   drivers/mmc/host/sdhci-brcmstb.c   | 2 +-

Acked-by: Florian Fainelli <florian.fainelli at broadcom.com> # Broadcom 
drivers
-- 
Florian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4221 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20230714/1de3789c/attachment.p7s>


More information about the linux-arm-kernel mailing list