[PATCH v2 10/18] hid/picolcd: Remove flag FBINFO_FLAG_DEFAULT from fbdev driver
Thomas Zimmermann
tzimmermann at suse.de
Thu Jul 13 05:58:30 PDT 2023
The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct
fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do
not set it.
Flags should signal differences from the default values. After cleaning
up all occurrences of FBINFO_DEFAULT, the token will be removed.
v2:
* fix commit message (Miguel)
Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
Acked-by: Sam Ravnborg <sam at ravnborg.org>
Acked-by: Benjamin Tissoires <benjamin.tissoires at redhat.com>
Acked-by: Bruno Prémont <bonbons at linux-vserver.org>
Cc: "Bruno Prémont" <bonbons at linux-vserver.org>
Cc: Jiri Kosina <jikos at kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires at redhat.com>
---
drivers/hid/hid-picolcd_fb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/hid/hid-picolcd_fb.c b/drivers/hid/hid-picolcd_fb.c
index dabcd054dad9..d726aaafb146 100644
--- a/drivers/hid/hid-picolcd_fb.c
+++ b/drivers/hid/hid-picolcd_fb.c
@@ -527,7 +527,6 @@ int picolcd_init_framebuffer(struct picolcd_data *data)
info->var = picolcdfb_var;
info->fix = picolcdfb_fix;
info->fix.smem_len = PICOLCDFB_SIZE*8;
- info->flags = FBINFO_FLAG_DEFAULT;
fbdata = info->par;
spin_lock_init(&fbdata->lock);
--
2.41.0
More information about the linux-arm-kernel
mailing list