[PATCH 4/5] ARM: dts: stm32: Add missing detach mailbox for DHCOR SoM

[Marek Vasut]

On 7/11/23 15:37, Alexandre TORGUE wrote:
> Hi Marek
> 
> On 7/11/23 04:05, Marek Vasut wrote:
>> On 5/18/23 03:12, Marek Vasut wrote:
>>> Add missing "detach" mailbox to this board to permit the CPU to inform
>>> the remote processor on a detach. This signal allows the remote 
>>> processor
>>> firmware to stop IPC communication and to reinitialize the resources for
>>> a re-attach.
>>>
>>> Without this mailbox, detach is not possible and kernel log contains the
>>> following warning to, so make sure all the STM32MP15xx platform DTs are
>>> in sync regarding the mailboxes to fix the detach issue and the warning:
>>> "
>>> stm32-rproc 10000000.m4: mbox_request_channel_byname() could not 
>>> locate channel named "detach"
>>> "
>>>
>>> Fixes: 6257dfc1c412 ("ARM: dts: stm32: Add coprocessor detach mbox on 
>>> stm32mp15x-dkx boards")
>>> Signed-off-by: Marek Vasut <marex at denx.de>
>>> ---
>>> Cc: Alexandre Torgue <alexandre.torgue at foss.st.com>
>>> Cc: Conor Dooley <conor+dt at kernel.org>
>>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt at linaro.org>
>>> Cc: Maxime Coquelin <mcoquelin.stm32 at gmail.com>
>>> Cc: Richard Cochran <richardcochran at gmail.com>
>>> Cc: Rob Herring <robh+dt at kernel.org>
>>> Cc: devicetree at vger.kernel.org
>>> Cc: kernel at dh-electronics.com
>>> Cc: linux-arm-kernel at lists.infradead.org
>>> Cc: linux-stm32 at st-md-mailman.stormreply.com
>>> ---
>>>   arch/arm/boot/dts/stm32mp15xx-dhcor-som.dtsi | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcor-som.dtsi 
>>> b/arch/arm/boot/dts/stm32mp15xx-dhcor-som.dtsi
>>> index 864960387e634..f0351f599a508 100644
>>> --- a/arch/arm/boot/dts/stm32mp15xx-dhcor-som.dtsi
>>> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcor-som.dtsi
>>> @@ -227,8 +227,8 @@ &iwdg2 {
>>>   &m4_rproc {
>>>       memory-region = <&retram>, <&mcuram>, <&mcuram2>, <&vdev0vring0>,
>>>               <&vdev0vring1>, <&vdev0buffer>;
>>> -    mboxes = <&ipcc 0>, <&ipcc 1>, <&ipcc 2>;
>>> -    mbox-names = "vq0", "vq1", "shutdown";
>>> +    mboxes = <&ipcc 0>, <&ipcc 1>, <&ipcc 2>, <&ipcc 3>;
>>> +    mbox-names = "vq0", "vq1", "shutdown", "detach";
>>>       interrupt-parent = <&exti>;
>>>       interrupts = <68 1>;
>>>       status = "okay";
>>
>> Is anything blocking 1/5..4/5 (i.e. the duplication in each board DT) 
>> patches from being applied ?
> 
> Nothing. I was just waiting to discuss with you about patch 5 at Prague 
> then merge windows.
> 
> So patch 1 to 4 applied on stm32-next.

Thank you