[PATCH v3 2/6] dt-bindings: phy: qcom,m31: Document qcom,m31 USB phy
Krzysztof Kozlowski
krzysztof.kozlowski at linaro.org
Tue Jul 11 02:03:38 PDT 2023
On 11/07/2023 10:51, Varadarajan Narayanan wrote:
> Document the M31 USB2 phy present in IPQ5332.
>
> Signed-off-by: Sricharan Ramabadhran <quic_srichara at quicinc.com>
> Signed-off-by: Varadarajan Narayanan <quic_varada at quicinc.com>
> ---
> v3:
> Incorporate review comments. Will bring in ipq5018 compatible
> string while posting ipq5018 usb patchset.
>
> v1:
> Rename qcom,m31.yaml -> qcom,ipq5332-usb-hsphy.yaml
> Drop default binding "m31,usb-hsphy"
> Add clock
> Remove 'oneOf' from compatible
> Remove 'qscratch' region from register space as it is not needed
> Remove reset-names
> Fix the example definition
> ---
> .../bindings/phy/qcom,ipq5332-usb-hsphy.yaml | 49 ++++++++++++++++++++++
> 1 file changed, 49 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml
>
> diff --git a/Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml b/Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml
> new file mode 100644
> index 0000000..2cfdd73
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/qcom,ipq5332-usb-hsphy.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: M31 (https://www.m31tech.com) USB PHY
The URL should rather go to description, not the title. Title is like
document title.
> +
> +maintainers:
> + - Sricharan Ramabadhran <quic_srichara at quicinc.com>
> + - Varadarajan Narayanan <quic_varada at quicinc.org>
> +
> +description:
> + USB M31 PHY found in Qualcomm IPQ5018, IPQ5332 SoCs.
> +
> +properties:
> + compatible:
> + enum:
> + - qcom,ipq5332-usb-hsphy
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + maxItems: 1
Drop
> + contains:
Drop
> + items:
> + - const: cfg_ahb
> +
> + resets:
> + maxItems: 1
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/qcom,ipq5332-gcc.h>
> + usbphy0: ipq5332-hsphy at 7b000 {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Best regards,
Krzysztof
More information about the linux-arm-kernel
mailing list