[PATCH] pwm: atmel: enable clk when pwm already enabled in bootloader

[Uwe Kleine-König]

On Tue, Jul 11, 2023 at 10:37:56AM +0800, Guiting Shen wrote:
> On Tue, Jul 11, 2023 at 03:15:50AM GMT+8, Uwe Kleine-König wrote:
> > Hello,
> > 
> > On Mon, Jul 10, 2023 at 05:00:45PM +0200, Thierry Reding wrote:
> >> On Mon, Jul 10, 2023 at 10:42:14PM +0800, Guiting Shen wrote:
> >>> +		err = clk_enable(atmel_pwm->clk);
> >>> +		if (err) {
> >>> +			dev_err(atmel_pwm->chip.dev, "enable clock error\n");
> >>
> >> Might be worth to include the error code in the error message to make it
> >> easier to diagnose where the issue is. Something like:
> >>
> >> 	dev_err(atmel_pwm->chip.dev, "failed to enable clock: %d\n", err);
> > 
> > Or (IMHO) still better:
> > 
> >  	dev_err(atmel_pwm->chip.dev, "failed to enable clock: %pe\n", ERR_PTR(err));
> > 
> 
> Ok, I will add it in v2 patch.
> 
> I also found that the clk_enable() of atmel_pwm_apply() do not include
> the error code in the error message. Do I also add this in v2 patch or
> in separate patch?

Sounds to me like a separate patch.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20230711/519ef66a/attachment.sig>