[RFT PATCH 1/3] arm64: dts: rockchip: correct audio-codec interrupt flag in eaidk-610
Krzysztof Kozlowski
krzysztof.kozlowski at linaro.org
Thu Jul 6 23:26:51 PDT 2023
On 06/07/2023 19:49, Robin Murphy wrote:
> On 2023-07-06 14:54, Krzysztof Kozlowski wrote:
>> On 05/07/2023 08:48, Krzysztof Kozlowski wrote:
>>> GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
>>> These are simple defines so they could be used in DTS but they will not
>>> have the same meaning: GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE.
>>>
>>> Correct the interrupt flags, assuming the author of the code wanted same
>>> logical behavior behind the name "ACTIVE_xxx", this is:
>>> ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW
>>
>> This should be HIGH in both cases. I will send a v2.
>
> Also the titles say "audio-codec" but they're all touching SDIO WiFi
> modules ;)
Thanks. Too much of copy-pasta.
Best regards,
Krzysztof
More information about the linux-arm-kernel
mailing list