回复: [PATCH net v2] net: thunderx: Fix resource leaks in a device_for_each_child_node() loop

王明-软件底层技术部 machel at vivo.com
Wed Jul 5 20:34:29 PDT 2023


Hi Markus.
Can you help me make a template to improve the wording? I have little experience in this area. Thank you😊
Regards,
Wang.
-----邮件原件-----
发件人: Markus Elfring <Markus.Elfring at web.de> 
发送时间: 2023年7月6日 3:33
收件人: 王明-软件底层技术部 <machel at vivo.com>; netdev at vger.kernel.org; kernel-janitors at vger.kernel.org; linux-arm-kernel at lists.infradead.org; David S. Miller <davem at davemloft.net>; Eric Dumazet <edumazet at google.com>; Jakub Kicinski <kuba at kernel.org>; Paolo Abeni <pabeni at redhat.com>; Sunil Goutham <sgoutham at marvell.com>
抄送: opensource.kernel <opensource.kernel at vivo.com>; LKML <linux-kernel at vger.kernel.org>
主题: Re: [PATCH net v2] net: thunderx: Fix resource leaks in a device_for_each_child_node() loop

> The device_for_each_child_node() loop in
> bgx_init_of_phy() function should have
> wnode_handle_put() before break
> which could avoid resource leaks.
> This patch could fix this bug.

Please choose a better imperative change suggestion.

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4#n94


How do you think about to add the tag “Fixes”?

Regards,
Markus


More information about the linux-arm-kernel mailing list