[PATCH] drivers: xilinx: Fix judgement of the return value from a devm_ioremap_resource() call

Markus Elfring Markus.Elfring at web.de
Wed Jul 5 07:56:37 PDT 2023


Would a subject like “[PATCH v2] dmaengine: xilinx: xdma: Fix a condition check in xdma_probe()”
be more appropriate?


> IS_ERR() fix devm_ioremap_resource function return judge.

I find this explanation improvable.
Would the following wording be helpful?


Replace a null pointer check by an error pointer check after a call
of the function “devm_ioremap_resource” in this function implementation.


> Could you help check it out?
> Thank you!

Such information does usually not belong to a change description.


How do you think about to add the tag “Fixes”?

Regards,
Markus



More information about the linux-arm-kernel mailing list