[PATCH] usb: mtu3: Fix possible use-before-initialization bug
Yu Hao
yhao016 at ucr.edu
Tue Jul 4 16:25:50 PDT 2023
The struct usb_ctrlrequest setup should be initialized in the function
ep0_read_setup(mtu, &setup). However, inside that function,
the variable count could be 0 and the struct usb_ctrlrequest setup
is not initialized. But there is a read for setup.bRequestType.
Signed-off-by: Yu Hao <yhao016 at ucr.edu>
---
drivers/usb/mtu3/mtu3_gadget_ep0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/mtu3/mtu3_gadget_ep0.c
b/drivers/usb/mtu3/mtu3_gadget_ep0.c
index e4fd1bb14a55..67034fa515d0 100644
--- a/drivers/usb/mtu3/mtu3_gadget_ep0.c
+++ b/drivers/usb/mtu3/mtu3_gadget_ep0.c
@@ -638,7 +638,7 @@ static int ep0_handle_setup(struct mtu3 *mtu)
__releases(mtu->lock)
__acquires(mtu->lock)
{
- struct usb_ctrlrequest setup;
+ struct usb_ctrlrequest setup = {};
struct mtu3_request *mreq;
int handled = 0;
--
2.34.1
More information about the linux-arm-kernel
mailing list