[PATCH 04/15] media: s5p-mfc: constify fw_name strings
Aakarsh Jain
aakarsh.jain at samsung.com
Tue Dec 26 00:53:21 PST 2023
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
> Sent: 24 December 2023 21:14
> To: Marek Szyprowski <m.szyprowski at samsung.com>; Andrzej Hajda
> <andrzej.hajda at intel.com>; Mauro Carvalho Chehab
> <mchehab at kernel.org>
> Cc: Aakarsh Jain <aakarsh.jain at samsung.com>; linux-fsd at tesla.coma; linux-
> samsung-soc at vger.kernel.org; Smitha T Murthy
> <smithatmurthy at gmail.com>; linux-arm-kernel at lists.infradead.org; linux-
> media at vger.kernel.org; linux-kernel at vger.kernel.org; Krzysztof Kozlowski
> <krzysztof.kozlowski at linaro.org>
> Subject: [PATCH 04/15] media: s5p-mfc: constify fw_name strings
>
> Constify stored pointers to firmware names for code safety. These are not
> modified by the driver.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
> ---
> drivers/media/platform/samsung/s5p-mfc/s5p_mfc_common.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_common.h
> b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_common.h
> index 5304f42c8c72..f33a755327ef 100644
> --- a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_common.h
> +++ b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_common.h
> @@ -227,7 +227,7 @@ struct s5p_mfc_variant {
> unsigned int port_num;
> u32 version_bit;
> struct s5p_mfc_buf_size *buf_size;
> - char *fw_name[MFC_FW_MAX_VERSIONS];
> + const char *fw_name[MFC_FW_MAX_VERSIONS];
> const char *clk_names[MFC_MAX_CLOCKS];
> int num_clocks;
> bool use_clock_gating;
>
> --
> 2.34.1
Reviewed-by: Aakarsh Jain <aakarsh.jain at samsung.com>
Thanks!
More information about the linux-arm-kernel
mailing list