[PATCH] dt-bindings: firmware: xilinx: Describe missing child nodes

Michal Simek michal.simek at amd.com
Tue Dec 19 23:57:25 PST 2023



On 12/20/23 08:53, Krzysztof Kozlowski wrote:
> On 19/12/2023 15:54, Michal Simek wrote:
>> Firmware node has more than fpga, aes and clock child nodes but also power,
>> reset, gpio, pinctrl and pcap which are not described yet.
>> All of them have binding in separate files but there is missing connection
>> to firmware node that's why describe it.
>>
>> Signed-off-by: Michal Simek <michal.simek at amd.com>
>> ---
>>
>>   .../firmware/xilinx/xlnx,zynqmp-firmware.yaml | 31 +++++++++++++++++++
>>   1 file changed, 31 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
>> index 3d578f98ae2c..0662544f86f0 100644
>> --- a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
>> +++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
>> @@ -53,6 +53,37 @@ properties:
>>         vector.
>>       type: object
>>   
>> +  zynqmp-power:
> 
> Can we rename it to "power-management" or if it is a power-domain
> provider to "power-controller"? Assuming nothing requires the old name?

I don't think there is any name dependency and node name can be renamed.

> 
> Also, all these nodes/properties look like not ordered by name, so maybe
> it is possible to add new nodes in some order?

I am fine with it. Do you want to sort it before adding new one or add new one 
and sort of all them?

Thanks,
Michal



More information about the linux-arm-kernel mailing list