[EXT] Re: [PATCH v2 3/5] dt-bindings: usb: ci-hdrc-usb2: add compatible and clock-names restriction for imx93
Xu Yang
xu.yang_2 at nxp.com
Tue Dec 19 18:23:18 PST 2023
Hi Krzysztof,
>
> On 18/12/2023 09:54, Xu Yang wrote:
> > The i.MX93 needs a wakup clock to work properly. This will add compatible
> > and restriction for i.MX93 platform.
> >
> > Signed-off-by: Xu Yang <xu.yang_2 at nxp.com>
> >
> > ---
> > Changes in v2:
> > - no changes
>
> No changes? Where is the v1 in such case?
Sorry, the changes should be new patch here.
>
> > ---
> > .../devicetree/bindings/usb/ci-hdrc-usb2.yaml | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml b/Documentation/devicetree/bindings/usb/ci-
> hdrc-usb2.yaml
> > index b7e664f7395b..4e22b369e43f 100644
> > --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
> > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
> > @@ -57,6 +57,7 @@ properties:
> > - enum:
> > - fsl,imx8mm-usb
> > - fsl,imx8mn-usb
> > + - fsl,imx93-usb
> > - const: fsl,imx7d-usb
> > - const: fsl,imx27-usb
> > - items:
> > @@ -411,6 +412,17 @@ allOf:
> > external-vbus-divider: false
> > samsung,picophy-pre-emp-curr-control: false
> > samsung,picophy-dc-vol-level-adjust: false
>
> Blank line
Okay.
>
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: fsl,imx93-usb
> > + then:
> > + properties:
> > + clock-names:
> > + items:
> > + - const: usb_ctrl_root_clk
> > + - const: usb_wakeup_clk
>
> What about all the reset? reg, interrupts? Maybe it is time to split the
> schema into common part and device-specific.
Why I need to consider reset, reg and interrupts? Should I add restrictions on
these too? I may not really understand your meaning.
Thanks,
Xu Yang
>
>
>
> Best regards,
> Krzysztof
More information about the linux-arm-kernel
mailing list