[PATCH v2 1/1] arm64: dts: ti: k3-am62-wakeup: Configure ti-sysc for wkup_uart0

Tony Lindgren tony at atomide.com
Mon Dec 18 23:06:25 PST 2023


* Nishanth Menon <nm at ti.com> [231218 16:19]:
> On 09:28-20231218, Tony Lindgren wrote:
> > * Nishanth Menon <nm at ti.com> [231215 16:00]:
> > > On 09:32-20231114, Tony Lindgren wrote:
> > > > -	wkup_uart0: serial at 2b300000 {
> > > > -		compatible = "ti,am64-uart", "ti,am654-uart";
> > > > -		reg = <0x00 0x2b300000 0x00 0x100>;
> > > > -		interrupts = <GIC_SPI 186 IRQ_TYPE_LEVEL_HIGH>;
> > > > +	target-module at 2b300000 {
> > > 
> > > should be  target-module at 2b300050 to match up with reg?
> > 
> > It's best to use the target-module IO range here, not the first reg.
> > The first reg may be tossed anywhere in the target module address
> > space depending on the device.
> > 
> > Ideally of course there would be just a standardized range of target
> > module related registers at the end of the IO space..
> 
> Sorry Tony, but the node address must matchup with the reg description
> for the node. I'd rather not sit and argue about this with automated
> tools and deal with trivial patches - so either tools like dtc need to
> ignore this or lets just fix the node address.

Oh sorry I did not mean to add a make W=1 dtbs warning. Yeah let's change
the node name to match the first reg to avoid the warning.

It should be also add some better checks for node names with ranges but
with just a few control registers.

Regards,

Tony



More information about the linux-arm-kernel mailing list