[PATCH v3 5/6] thermal: sun8i: add support for H616 THS controller

Andre Przywara andre.przywara at arm.com
Sun Dec 10 16:05:28 PST 2023


On Sat, 9 Dec 2023 13:44:34 +0300
Maksim Kiselev <bigunclemax at gmail.com> wrote:

Hi Maksim,

> Hi Martin, Andre.
> 
> May I inquire? Why do we need a separate sun50i_h616_ths_calibrate() 
> function? Why can't we just extend an existing sun50i_h6_ths_calibrate()?
> 
> At my glance the calculations in both functions are the same. We just 
> need to handle a special case for the 4th sensor.

You seem to be right, they are indeed the same, just written slightly
differently. Do you already have any patches that unify that?
I don't know if Martin or I find time to do it this week, but we could
also optimise this later.

Cheers,
Andre



More information about the linux-arm-kernel mailing list