[PATCH v3 3/4] staging: vc04_services: Drop vchiq_log_trace() in favour of dev_dbg

[Stefan Wahren]

Hi Dan,

Am 09.12.23 um 07:27 schrieb Dan Carpenter:
> On Fri, Dec 08, 2023 at 01:08:04PM +0100, Stefan Wahren wrote:
>>> @@ -1425,7 +1416,7 @@ vchiq_use_internal(struct vchiq_state *state, struct vchiq_service *service,
>>>    	}
>>>
>>>    out:
>>> -	vchiq_log_trace(state->dev, VCHIQ_SUSPEND, "%s exit %d", __func__, ret);
>>> +	dev_dbg(state->dev, "suspend: exit %d\n", ret);
>> In case we want to keep this kind of debug messages, i prefer to have a
>> common format:
>>
>> returning %d vs exit %d
> Someone was trying to make ftrace track return values...  Whatever
> happened with that work?
this feature has been merged, but it doesn't seem to be available for arm:

find -name Kconfig | xargs grep HAVE_FUNCTION_GRAPH_RETVAL
./kernel/trace/Kconfig:config HAVE_FUNCTION_GRAPH_RETVAL
./kernel/trace/Kconfig:    depends on HAVE_FUNCTION_GRAPH_RETVAL
./arch/x86/Kconfig:    select HAVE_FUNCTION_GRAPH_RETVAL    if
HAVE_FUNCTION_GRAPH_TRACER
./arch/arm64/Kconfig:    select HAVE_FUNCTION_GRAPH_RETVAL if
HAVE_FUNCTION_GRAPH_TRACER
./arch/s390/Kconfig:    select HAVE_FUNCTION_GRAPH_RETVAL
./arch/riscv/Kconfig:    select HAVE_FUNCTION_GRAPH_RETVAL if
HAVE_FUNCTION_GRAPH_TRACER
./arch/loongarch/Kconfig:    select HAVE_FUNCTION_GRAPH_RETVAL if
HAVE_FUNCTION_GRAPH_TRACER

These debug messages are only in the error path, so i'm not sure if
someone what to hunt bugs by searching all that return values without
knowing which function is possibly affected.
>
> regards,
> dan carpenter
>