[PATCH v4 2/2] dt-bindings: media: remove nokia,n900-ir as pwm-ir-tx is compatible

Krzysztof Kozlowski krzk at kernel.org
Sun Aug 27 00:53:44 PDT 2023


On 26/08/2023 22:39, Sean Young wrote:
> On Sat, Aug 26, 2023 at 09:54:04PM +0200, Krzysztof Kozlowski wrote:
>> On 26/08/2023 19:17, Sean Young wrote:
>>> The generic pwm-ir-tx driver works for the Nokia n900, so nokia,n900-ir
>>> can be removed.
>>>
>>> Signed-off-by: Sean Young <sean at mess.org>
>>
>> Please use scripts/get_maintainers.pl to get a list of necessary people
>> and lists to CC. It might happen, that command when run on an older
>> kernel, gives you outdated entries. Therefore please be sure you base
>> your patches on recent Linux kernel.
>>
>> You missed at least devicetree list (maybe more), so this won't be
>> tested by automated tooling. Performing review on untested code might be
>> a waste of time.
> 
> You are right, I -- again -- messed up. The Cc: list for 1/2 and 2/2 got
> mixed up.
> 
> I am sorry about this, it's getting embarrassing now.
> 
> Is there any tooling which does this automagically? I'm copying and
> pasting the output of scripts/get_maintainers.pl into shell scripts,
> which is very error-prone (as evidenced by today's mistake).

I am using this:
https://github.com/krzk/tools/blob/master/linux/.bash_aliases_linux#L91

Other option, sending each patch to separate recipients, is:
[sendemail.linux]
	tocmd ="scripts/get_maintainer.pl --no-git --no-git-fallback --no-l
--no-roles --no-rolestats"
	cccmd ="scripts/get_maintainer.pl --no-git --no-git-fallback --no-m
--no-roles --no-rolestats"
	confirm = always

and then git send-email --identity=....

Best regards,
Krzysztof




More information about the linux-arm-kernel mailing list