[PATCH 1/3] dt-bindings: thermal: sun8i: Add binding for H616 THS controller
Andre Przywara
andre.przywara at arm.com
Fri Aug 18 03:37:46 PDT 2023
On Fri, 18 Aug 2023 10:43:16 +0200
Martin Botka <martin.botka at somainline.org> wrote:
> Add binding for H616 THS controller.
You could add:
This controller is similar to the H6, but covers four sensors and uses
slightly different calibration methods.
One minor question below:
> Signed-off-by: Martin Botka <martin.botka at somainline.org>
> ---
> .../devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml
> index fbd4212285e2..79692f8360f5 100644
> --- a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml
> +++ b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml
> @@ -20,6 +20,7 @@ properties:
> - allwinner,sun50i-a100-ths
> - allwinner,sun50i-h5-ths
> - allwinner,sun50i-h6-ths
> + - allwinner,sun50i-h616-ths
>
> clocks:
> minItems: 1
> @@ -63,6 +64,7 @@ allOf:
> enum:
> - allwinner,sun50i-a100-ths
> - allwinner,sun50i-h6-ths
> + - allwinner,sun50i-h616-ths
>
> then:
> properties:
> @@ -107,6 +109,7 @@ allOf:
> - allwinner,sun50i-a100-ths
> - allwinner,sun50i-h5-ths
> - allwinner,sun50i-h6-ths
> + - allwinner,sun50i-h616-ths
I wonder if this list can be negated. Because what this currently says is:
"Every controller except the A83T one requires clocks and resets."
Can we write this more explicitly?
Regardless:
Reviewed-by: Andre Przywara <andre.przywara at arm.com>
Cheers,
Andre
>
> then:
> required:
>
More information about the linux-arm-kernel
mailing list