[PATCH net-next v4 7/9] ice: implement dpll interface to control cgu

Jiri Pirko jiri at resnulli.us
Fri Aug 11 23:19:45 PDT 2023


Fri, Aug 11, 2023 at 10:03:38PM CEST, vadim.fedorenko at linux.dev wrote:

[...]


>@@ -4690,6 +4694,8 @@ static void ice_deinit_features(struct ice_pf *pf)
> 		ice_gnss_exit(pf);
> 	if (test_bit(ICE_FLAG_PTP_SUPPORTED, pf->flags))
> 		ice_ptp_release(pf);
>+	if (test_bit(ICE_FLAG_DPLL, pf->flags))

This is a duplicate test as you test it as a first thing in
ice_dpll_deinit(). But nevermind this nit, let's have v4 merged
if possible.


>+		ice_dpll_deinit(pf);
> }
> 
> static void ice_init_wakeup(struct ice_pf *pf)
>-- 
>2.27.0
>



More information about the linux-arm-kernel mailing list