[PATCH -next v2 2/2] media: nxp: Remove a redundant dev_err() for platform_get_irq()
Ruan Jinjie
ruanjinjie at huawei.com
Wed Aug 9 20:46:41 PDT 2023
There is no need to call the dev_err() function directly to print a custom
message when handling an error from platform_get_irq() function as
it is going to display an appropriate error message in case of a failure.
Signed-off-by: Ruan Jinjie <ruanjinjie at huawei.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
Reviewed-by: Mirela Rabulea <mirela.rabulea at nxp.com>
---
v2:
- Update the commit title.
- Split into 2 patches.
---
drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c
index c4454aa1cb34..65d20e9bae69 100644
--- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c
+++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c
@@ -791,7 +791,6 @@ int mxc_isi_pipe_init(struct mxc_isi_dev *isi, unsigned int id)
irq = platform_get_irq(to_platform_device(isi->dev), id);
if (irq < 0) {
- dev_err(pipe->isi->dev, "Failed to get IRQ (%d)\n", irq);
ret = irq;
goto error;
}
--
2.34.1
More information about the linux-arm-kernel
mailing list