[PATCH -next 6/6] brcm80211: Remove an unnecessary ternary operator

[Ruan Jinjie]

On 2023/8/7 9:42, Ping-Ke Shih wrote:
> 
> 
>> -----Original Message-----
>> From: Ruan Jinjie <ruanjinjie at huawei.com>
>> Sent: Friday, August 4, 2023 11:54 AM
>> To: sgoutham at marvell.com; davem at davemloft.net; edumazet at google.com; kuba at kernel.org; pabeni at redhat.com;
>> jesse.brandeburg at intel.com; anthony.l.nguyen at intel.com; tariqt at nvidia.com; s.shtylyov at omp.ru;
>> aspriel at gmail.com; franky.lin at broadcom.com; hante.meuleman at broadcom.com; kvalo at kernel.org;
>> richardcochran at gmail.com; yoshihiro.shimoda.uh at renesas.com; ruanjinjie at huawei.com;
>> u.kleine-koenig at pengutronix.de; mkl at pengutronix.de; lee at kernel.org; set_pte_at at outlook.com;
>> linux-arm-kernel at lists.infradead.org; netdev at vger.kernel.org; intel-wired-lan at lists.osuosl.org;
>> linux-rdma at vger.kernel.org; linux-renesas-soc at vger.kernel.org; linux-wireless at vger.kernel.org;
>> brcm80211-dev-list.pdl at broadcom.com; SHA-cyfmac-dev-list at infineon.com
>> Subject: [PATCH -next 6/6] brcm80211: Remove an unnecessary ternary operator
>>
>> There is a ternary operator, the true or false judgement of which
>> is unnecessary in C language semantics.
>>
>> Signed-off-by: Ruan Jinjie <ruanjinjie at huawei.com>
>> ---
>>  drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c
>> b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c
>> index 8580a2754789..8328b22829c5 100644
>> --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c
>> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c
>> @@ -27351,8 +27351,7 @@ static int wlc_phy_cal_rxiq_nphy_rev3(struct brcms_phy *pi,
>>
>>         for (rx_core = 0; rx_core < pi->pubpi.phy_corenum; rx_core++) {
>>
>> -               skip_rxiqcal =
>> -                       ((rxcore_state & (1 << rx_core)) == 0) ? true : false;
>> +               skip_rxiqcal = (rxcore_state & (1 << rx_core)) == 0;
> 
> skip_rxiqcal = !(rxcore_state & (1 << rx_core));


Thank you! I'll improve it sooner.

> 
>>
>>                 wlc_phy_rxcal_physetup_nphy(pi, rx_core);
>>
>> --
>> 2.34.1
>>
>>
>> ------Please consider the environment before printing this e-mail.
>