[PATCH -next 3/6] net/mlx4: Remove an unnecessary ternary operator

[Ruan Jinjie]

On 2023/8/7 9:41, Ping-Ke Shih wrote:
> 
> 
>> -----Original Message-----
>> From: Ruan Jinjie <ruanjinjie at huawei.com>
>> Sent: Friday, August 4, 2023 11:54 AM
>> To: sgoutham at marvell.com; davem at davemloft.net; edumazet at google.com; kuba at kernel.org; pabeni at redhat.com;
>> jesse.brandeburg at intel.com; anthony.l.nguyen at intel.com; tariqt at nvidia.com; s.shtylyov at omp.ru;
>> aspriel at gmail.com; franky.lin at broadcom.com; hante.meuleman at broadcom.com; kvalo at kernel.org;
>> richardcochran at gmail.com; yoshihiro.shimoda.uh at renesas.com; ruanjinjie at huawei.com;
>> u.kleine-koenig at pengutronix.de; mkl at pengutronix.de; lee at kernel.org; set_pte_at at outlook.com;
>> linux-arm-kernel at lists.infradead.org; netdev at vger.kernel.org; intel-wired-lan at lists.osuosl.org;
>> linux-rdma at vger.kernel.org; linux-renesas-soc at vger.kernel.org; linux-wireless at vger.kernel.org;
>> brcm80211-dev-list.pdl at broadcom.com; SHA-cyfmac-dev-list at infineon.com
>> Subject: [PATCH -next 3/6] net/mlx4: Remove an unnecessary ternary operator
>>
>> There is a ternary operator, the true or false judgement
>> of which is unnecessary in C language semantics.
>>
>> Signed-off-by: Ruan Jinjie <ruanjinjie at huawei.com>
>> ---
>>  drivers/net/ethernet/mellanox/mlx4/port.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/mellanox/mlx4/port.c b/drivers/net/ethernet/mellanox/mlx4/port.c
>> index 256a06b3c096..1c289488d050 100644
>> --- a/drivers/net/ethernet/mellanox/mlx4/port.c
>> +++ b/drivers/net/ethernet/mellanox/mlx4/port.c
>> @@ -176,7 +176,7 @@ static bool mlx4_need_mf_bond(struct mlx4_dev *dev)
>>         mlx4_foreach_port(i, dev, MLX4_PORT_TYPE_ETH)
>>                 ++num_eth_ports;
>>
>> -       return (num_eth_ports ==  2) ? true : false;
>> +       return num_eth_ports ==  2;
> 
> It should be one space between '=' and '2'.

Thank you! I'll improve it sooner.

> 
>>  }
>>
>>  int __mlx4_register_mac(struct mlx4_dev *dev, u8 port, u64 mac)
>> --
>> 2.34.1
>>
>>
>> ------Please consider the environment before printing this e-mail.
>