[PATCH 2/4] net: ti: icss-iep: Add IEP driver
Md Danish Anwar
a0501179 at ti.com
Thu Aug 3 23:27:08 PDT 2023
On 03/08/23 8:46 pm, Simon Horman wrote:
> On Thu, Aug 03, 2023 at 04:31:51PM +0530, MD Danish Anwar wrote:
>> From: Roger Quadros <rogerq at ti.com>
>>
>> Add a driver for Industrial Ethernet Peripheral (IEP) block of PRUSS to
>> support timestamping of ethernet packets and thus support PTP and PPS
>> for PRU ethernet ports.
>>
>> Signed-off-by: Roger Quadros <rogerq at ti.com>
>> Signed-off-by: Lokesh Vutla <lokeshvutla at ti.com>
>> Signed-off-by: Murali Karicheri <m-karicheri2 at ti.com>
>> Signed-off-by: Vignesh Raghavendra <vigneshr at ti.com>
>> Signed-off-by: MD Danish Anwar <danishanwar at ti.com>
>
> ...
>
>> +static int icss_iep_pps_enable(struct icss_iep *iep, int on)
>> +{
>> + int ret = 0;
>> + struct timespec64 ts;
>> + struct ptp_clock_request rq;
>> + unsigned long flags;
>> + u64 ns;
>
> For networking code, please arrange local variables in reverse xmas tree
> order - longest line to shortest.
>
> https://github.com/ecree-solarflare/xmastree is your friend here.
>
> ...
Sure Simon, I will take care of this in next revision.
--
Thanks and Regards,
Danish.
More information about the linux-arm-kernel
mailing list