[PATCH -next v2] gpio: clps711x: remove redundant of_match_ptr()
Zhu Wang
wangzhu9 at huawei.com
Tue Aug 1 19:54:31 PDT 2023
The driver depends on CONFIG_OF, so it is not necessary to use
of_match_ptr() here.
Even for drivers that do not depend on CONFIG_OF, it's almost always
better to leave out the of_match_ptr(), since the only thing it can
possibly do is to save a few bytes of .text if a driver can be used both
with and without it. Hence we remove of_match_ptr().
Signed-off-by: Zhu Wang <wangzhu9 at huawei.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
---
Changes in v2:
- Change of_match_ptr to of_match_ptr() in the commit message.
- Drop __maybe_unused.
---
drivers/gpio/gpio-clps711x.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-clps711x.c b/drivers/gpio/gpio-clps711x.c
index 75f6f8d4323e..d69a24dd4828 100644
--- a/drivers/gpio/gpio-clps711x.c
+++ b/drivers/gpio/gpio-clps711x.c
@@ -67,7 +67,7 @@ static int clps711x_gpio_probe(struct platform_device *pdev)
return devm_gpiochip_add_data(&pdev->dev, gc, NULL);
}
-static const struct of_device_id __maybe_unused clps711x_gpio_ids[] = {
+static const struct of_device_id clps711x_gpio_ids[] = {
{ .compatible = "cirrus,ep7209-gpio" },
{ }
};
@@ -76,7 +76,7 @@ MODULE_DEVICE_TABLE(of, clps711x_gpio_ids);
static struct platform_driver clps711x_gpio_driver = {
.driver = {
.name = "clps711x-gpio",
- .of_match_table = of_match_ptr(clps711x_gpio_ids),
+ .of_match_table = clps711x_gpio_ids,
},
.probe = clps711x_gpio_probe,
};
--
2.17.1
More information about the linux-arm-kernel
mailing list