[PATCH] gpio: sama5d2-piobu: remove unneeded call to platform_set_drvdata()

Bartosz Golaszewski brgl at bgdev.pl
Tue Aug 1 12:28:02 PDT 2023


On Fri, Jul 28, 2023 at 8:25 PM Andrei Coardos <aboutphysycs at gmail.com> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>
> Reviewed-by: Alexandru Ardelean <alex at shruggie.ro>
> Signed-off-by: Andrei Coardos <aboutphysycs at gmail.com>
> ---
>  drivers/gpio/gpio-sama5d2-piobu.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-sama5d2-piobu.c b/drivers/gpio/gpio-sama5d2-piobu.c
> index 767c33ae3213..d89da7300ddd 100644
> --- a/drivers/gpio/gpio-sama5d2-piobu.c
> +++ b/drivers/gpio/gpio-sama5d2-piobu.c
> @@ -189,7 +189,6 @@ static int sama5d2_piobu_probe(struct platform_device *pdev)
>         if (!piobu)
>                 return -ENOMEM;
>
> -       platform_set_drvdata(pdev, piobu);
>         piobu->chip.label = pdev->name;
>         piobu->chip.parent = &pdev->dev;
>         piobu->chip.owner = THIS_MODULE,
> --
> 2.34.1
>

Applied, thanks!

Bartosz



More information about the linux-arm-kernel mailing list