[PATCH 1/2] spi: cadence-quadspi: use macro SIMPLE_DEV_PM_OPS
Gole, Dhruva
d-gole at ti.com
Tue Apr 18 07:17:57 PDT 2023
Hi Mark, Thanks for going through my patch.
On 4/18/2023 6:22 PM, Mark Brown wrote:
> On Mon, Apr 17, 2023 at 02:40:26PM +0530, Dhruva Gole wrote:
>
>> -static const struct dev_pm_ops cqspi__dev_pm_ops = {
>> - .suspend = cqspi_suspend,
>> - .resume = cqspi_resume,
>> -};
>> +static SIMPLE_DEV_PM_OPS(cqspi__dev_pm_ops, cqspi_suspend, cqspi_resume);
>>
>> #define CQSPI_DEV_PM_OPS (&cqspi__dev_pm_ops)
>> #else
> These days you should use DEFINE_SIMPLE_DEV_PM_OPS() instead.
Sure, I can respin this series with this macro instead,
https://elixir.bootlin.com/linux/v6.1/source/include/linux/pm.h#L399
So essentially it will look like,
static DEFINE_SIMPLE_DEV_PM_OPS(cqspi__dev_pm_ops, cqspi_suspend, cqspi_resume);
Are there any other improvements you'd like me to make in my next revision of this series?
--
Regards,
Dhruva Gole <d-gole at ti.com>
More information about the linux-arm-kernel
mailing list