[PATCH] soc: ti: smartreflex: Simplify getting the opam_sr pointer

Arnd Bergmann arnd at arndb.de
Fri Apr 14 09:04:35 PDT 2023


On Wed, Apr 12, 2023, at 16:25, Uwe Kleine-König wrote:
> Hello,
>
> [Cc += Tony Lindgren + Arnd Bergmann who did care about the last change
> to this driver]
>
> On Wed, Oct 12, 2022 at 04:00:32PM +0200, Uwe Kleine-König wrote:
>> The probe function stores the sr_info pointer using
>> platform_set_drvdata(). Use the corresponding platform_get_drvdata() to
>> retrieve that pointer in the remove and shutdown functions.
>> 
>> This simplifies these functions and makes error handling unnecessary.
>> This is a good thing as at least for .remove() returning an error code
>> doesn't have the desired effect.
>> 
>> This is a preparation for making platform remove callbacks return void.
>> 
>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
>
> This patch still applies to v6.3-rc1, but I didn't get any feedback
> since 6 months now. I need this change to eventually make
> platform_driver's remove callback return void.

Applied to the soc/drivers branch for 6.4 now.

     Arnd



More information about the linux-arm-kernel mailing list