[net-next PATCH v6 06/16] net: phy: phy_device: Call into the PHY driver to set LED brightness

Florian Fainelli f.fainelli at gmail.com
Thu Apr 13 06:57:51 PDT 2023



On 3/27/2023 7:10 AM, Christian Marangi wrote:
> From: Andrew Lunn <andrew at lunn.ch>
> 
> Linux LEDs can be software controlled via the brightness file in /sys.
> LED drivers need to implement a brightness_set function which the core
> will call. Implement an intermediary in phy_device, which will call
> into the phy driver if it implements the necessary function.
> 
> Signed-off-by: Andrew Lunn <andrew at lunn.ch>
> Signed-off-by: Christian Marangi <ansuelsmth at gmail.com>

Reviewed-by: Florian Fainelli <f.fainelli at gmail.com>

> +	int (*led_brightness_set)(struct phy_device *dev,
> +				  u32 index, enum led_brightness value);

I think I would have made this an u8, 4 billion LEDs, man, that's a lot!
-- 
Florian



More information about the linux-arm-kernel mailing list