[xilinx-xlnx:xlnx_rebase_v6.1_LTS 209/1065] include/linux/bits.h:36:18: warning: right shift count is negative
kernel test robot
lkp at intel.com
Wed Apr 12 14:53:26 PDT 2023
tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v6.1_LTS
head: e5753363b5e03fc0a3055d5476c6cca93e9ea28b
commit: b8dc3b1039ae479b6fe43682bbe923d43ba4d578 [209/1065] ptp: Add Xilinx PTP timer driver
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20230413/202304130535.YIBPsBLM-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/Xilinx/linux-xlnx/commit/b8dc3b1039ae479b6fe43682bbe923d43ba4d578
git remote add xilinx-xlnx https://github.com/Xilinx/linux-xlnx
git fetch --no-tags xilinx-xlnx xlnx_rebase_v6.1_LTS
git checkout b8dc3b1039ae479b6fe43682bbe923d43ba4d578
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash drivers/irqchip/ drivers/media/i2c/ drivers/media/mc/ drivers/net/ethernet/xilinx/ drivers/ptp/ drivers/spi/ drivers/staging/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp at intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304130535.YIBPsBLM-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from include/linux/ratelimit_types.h:5,
from include/linux/ratelimit.h:5,
from include/linux/dev_printk.h:16,
from include/linux/device.h:15,
from drivers/ptp/ptp_xilinx.c:8:
drivers/ptp/ptp_xilinx.c: In function 'xlnx_tod_read':
>> include/linux/bits.h:36:18: warning: right shift count is negative [-Wshift-count-negative]
36 | (~UL(0) >> (BITS_PER_LONG - 1 - (h))))
| ^~
include/linux/bits.h:38:38: note: in expansion of macro '__GENMASK'
38 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
| ^~~~~~~~~
drivers/ptp/ptp_xilinx.c:60:41: note: in expansion of macro 'GENMASK'
60 | #define XPTPTIMER_MAX_SEC_MASK GENMASK(XPTPTIMER_MAX_SEC_SIZE - 1, 0)
| ^~~~~~~
drivers/ptp/ptp_xilinx.c:114:51: note: in expansion of macro 'XPTPTIMER_MAX_SEC_MASK'
114 | ts->tv_sec = (((u64)sech << 32) | secl) & XPTPTIMER_MAX_SEC_MASK;
| ^~~~~~~~~~~~~~~~~~~~~~
In file included from include/linux/bits.h:6:
drivers/ptp/ptp_xilinx.c: In function 'xlnx_ptp_adjtime':
include/vdso/bits.h:7:40: warning: left shift count >= width of type [-Wshift-count-overflow]
7 | #define BIT(nr) (UL(1) << (nr))
| ^~
drivers/ptp/ptp_xilinx.c:62:41: note: in expansion of macro 'BIT'
62 | #define XPTPTIMER_TOD_OFFSET_NEG BIT(47)
| ^~~
drivers/ptp/ptp_xilinx.c:251:24: note: in expansion of macro 'XPTPTIMER_TOD_OFFSET_NEG'
251 | sign = XPTPTIMER_TOD_OFFSET_NEG;
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/ptp/ptp_xilinx.c: In function 'xlnx_ptp_timer_probe':
>> include/linux/bits.h:36:18: warning: right shift count is negative [-Wshift-count-negative]
36 | (~UL(0) >> (BITS_PER_LONG - 1 - (h))))
| ^~
include/linux/bits.h:38:38: note: in expansion of macro '__GENMASK'
38 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
| ^~~~~~~~~
drivers/ptp/ptp_xilinx.c:60:41: note: in expansion of macro 'GENMASK'
60 | #define XPTPTIMER_MAX_SEC_MASK GENMASK(XPTPTIMER_MAX_SEC_SIZE - 1, 0)
| ^~~~~~~
drivers/ptp/ptp_xilinx.c:388:50: note: in expansion of macro 'XPTPTIMER_MAX_SEC_MASK'
388 | ts.tv_sec = (((u64)sech << 32) | secl) & XPTPTIMER_MAX_SEC_MASK;
| ^~~~~~~~~~~~~~~~~~~~~~
>> include/linux/bits.h:36:18: warning: right shift count is negative [-Wshift-count-negative]
36 | (~UL(0) >> (BITS_PER_LONG - 1 - (h))))
| ^~
include/linux/bits.h:38:38: note: in expansion of macro '__GENMASK'
38 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
| ^~~~~~~~~
drivers/ptp/ptp_xilinx.c:60:41: note: in expansion of macro 'GENMASK'
60 | #define XPTPTIMER_MAX_SEC_MASK GENMASK(XPTPTIMER_MAX_SEC_SIZE - 1, 0)
| ^~~~~~~
drivers/ptp/ptp_xilinx.c:394:51: note: in expansion of macro 'XPTPTIMER_MAX_SEC_MASK'
394 | tsp.tv_sec = (((u64)sech << 32) | secl) & XPTPTIMER_MAX_SEC_MASK;
| ^~~~~~~~~~~~~~~~~~~~~~
vim +36 include/linux/bits.h
295bcca84916cb Rikard Falkeborn 2020-04-06 33
295bcca84916cb Rikard Falkeborn 2020-04-06 34 #define __GENMASK(h, l) \
95b980d62d52c4 Masahiro Yamada 2019-07-16 35 (((~UL(0)) - (UL(1) << (l)) + 1) & \
95b980d62d52c4 Masahiro Yamada 2019-07-16 @36 (~UL(0) >> (BITS_PER_LONG - 1 - (h))))
295bcca84916cb Rikard Falkeborn 2020-04-06 37 #define GENMASK(h, l) \
295bcca84916cb Rikard Falkeborn 2020-04-06 38 (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
8bd9cb51daac89 Will Deacon 2018-06-19 39
:::::: The code at line 36 was first introduced by commit
:::::: 95b980d62d52c4c1768ee719e8db3efe27ef52b2 linux/bits.h: make BIT(), GENMASK(), and friends available in assembly
:::::: TO: Masahiro Yamada <yamada.masahiro at socionext.com>
:::::: CC: Linus Torvalds <torvalds at linux-foundation.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
More information about the linux-arm-kernel
mailing list