[PATCH v2 3/3] p54spi: convert to devicetree

Krzysztof Kozlowski krzk at kernel.org
Fri Apr 7 00:10:48 PDT 2023


On 04/04/2023 10:24, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd at arndb.de>
> 
> The Prism54 SPI driver hardcodes GPIO numbers and expects users to
> pass them as module parameters, apparently a relic from its life as a
> staging driver. This works because there is only one user, the Nokia
> N8x0 tablet.
> 
> Convert this to the gpio descriptor interface and DT based probing
> to improve this and simplify the code at the same time.
> 
> Acked-by: Christian Lamparter <chunkeey at gmail.com>
> Signed-off-by: Arnd Bergmann <arnd at arndb.de>
> ---
>  MAINTAINERS                                |  1 +
>  arch/arm/mach-omap2/board-n8x0.c           | 18 ------
>  drivers/net/wireless/intersil/p54/p54spi.c | 71 ++++++++--------------
>  drivers/net/wireless/intersil/p54/p54spi.h |  3 +
>  4 files changed, 30 insertions(+), 63 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4f57deee1a08..9b08dcea913a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -15793,6 +15793,7 @@ M:	Christian Lamparter <chunkeey at googlemail.com>
>  L:	linux-wireless at vger.kernel.org
>  S:	Maintained
>  W:	https://wireless.wiki.kernel.org/en/users/Drivers/p54
> +F:	Documentation/devicetree/bindings/net/wireless/st,stlc45xx.yaml
>  F:	drivers/net/wireless/intersil/p54/

This hunk should be rather part of your patch #1.



Best regards,
Krzysztof




More information about the linux-arm-kernel mailing list