[PATCH 1/3] spi: s3c64xx: support spi polling mode using devicetree

Krzysztof Kozlowski krzysztof.kozlowski at linaro.org
Tue Apr 4 22:42:53 PDT 2023


On 04/04/2023 08:00, Jaewon Kim wrote:
> This patch adds new 'samsung,spi-polling' property to support polling mode.

Do not use "This commit/patch", but imperative mood. See:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

Also, binding should be before its usage.

> In some environments, polling mode is required even if DMA is supported.

Why? What are these environments? You need to explain all this in commit
msg.

> Changed it to support not only with quick but also optinally with

typo: optionally

> devicetree.
> 

Best regards,
Krzysztof




More information about the linux-arm-kernel mailing list