[PATCH v2 2/3] dma/ti: convert k3-udma to module

Kevin Hilman khilman at baylibre.com
Thu Sep 29 16:31:23 PDT 2022


Hi Vinod,

Vinod Koul <vkoul at kernel.org> writes:

> On 27-09-22, 16:08, Kevin Hilman wrote:
>> Currently k3-udma driver is built as separate platform drivers with a
>> shared probe and identical code path, just differnet platform data.
>> 
>> To enable to build as module, convert the separate platform driver
>> into a single module_platform_driver with the data selection done via
>> compatible string and of_match.  The separate of_match tables are also
>> combined into a single table to avoid the multiple calls to
>> of_match_node()
>> 
>> Since all modern TI platforms using this are DT enabled, the removal
>> of separate platform_drivers shoul should nave no functional change.
>
> drop extra shoul
>
> Please change subsystem tag to dmaengine: ti: xxxx for this and next
> patch

OK.

>> 
>> Signed-off-by: Kevin Hilman <khilman at baylibre.com>
>> Acked-by: Peter Ujfalusi <peter.ujfalusi at gmail.com>                                                                                                                            
>
> this has trailing whitespaces, maybe copy paste error

Yup.  Thanks for the review.  Will respin.

Kevin



More information about the linux-arm-kernel mailing list