[PATCH] ARM: dts: kirkwood: Add Zyxel NSA310S board

Andrew Lunn andrew at lunn.ch
Thu Sep 29 05:53:15 PDT 2022


> +// SPDX-License-Identifier: GPL-2.0-only

Same license comment. However, you can only change the license if it
is your code. If you did the conversion from a board setup file to DT,
you can change the license. If somebody else did that and you are just
submitting it, then we need to keep to GPL-2.0-only.

> +	regulators {
> +		compatible = "simple-bus";
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		pinctrl-0 = <&pmx_power>;
> +		pinctrl-names = "default";

The modern way to do regulators is to no longer user a container node.
Most of the existing kirkwood DTS files are from long before this was
introduced, so they do have a container. But new files should probably
do it the 'new' way.

   Andrew



More information about the linux-arm-kernel mailing list