[PATCH] KVM: arm64: Cleanup the __get_fault_info() to take out the code that validates HPFAR

Mingwei Zhang mizhang at google.com
Tue Sep 27 10:38:22 PDT 2022


> > +static inline bool __hpfar_is_valid(u64 esr)
>
> Unlike what the name implies, this function returns true for some
> cases that HPFAR is not valid (i.e. SEA).  I think the function
> returns true when KVM doesn't need HPFAR, or when HPFAR is valid.
> IMHO the name might be a bit misleading, although I don't have
> a good name for this.  It would be nice to state that in the
> comment at least.
>
> Thank you,
> Reiji
>

Yeah, I agree with you Reiji that the name does not reflect the
meaning of the function. So I was thinking about other names like
__translate_hpfar_to_far_needed().



More information about the linux-arm-kernel mailing list