[PATCH linux-next] PCI: iproc: Remove the unneeded result variable

Lorenzo Pieralisi lpieralisi at kernel.org
Tue Sep 27 05:07:52 PDT 2022


[+Greg]

On Tue, Sep 06, 2022 at 04:25:20PM -0500, Bjorn Helgaas wrote:
> On Tue, Sep 06, 2022 at 07:16:36AM +0000, cgel.zte at gmail.com wrote:
> > From: ye xingchen <ye.xingchen at zte.com.cn>
> > 
> > Return the value iproc_pcie_setup_ib() directly instead of storing it in
> > another redundant variable.
> > 
> > Reported-by: Zeal Robot <zealci at zte.com.cn>
> > Signed-off-by: ye xingchen <ye.xingchen at zte.com.cn>
> 
> This patch itself is fine, but was posted by cgel.zte at gmail.com, not by
> "ye xingchen <ye.xingchen at zte.com.cn>", so it needs another signoff
> and full name so the chain is complete.  For more details see:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=v5.18#n363

Greg, Bjorn,

I believe that appending a SoB like this myself is fine:

Signed-off-by: CGEL ZTE <cgel.zte at gmail.com>

It is a SOB already in kernel commit logs - I assume
that's the right thing to do in this case, please
let me know if it isn't and what should we do instead.

Thanks,
Lorenzo

> Bjorn
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel



More information about the linux-arm-kernel mailing list