[PATCH -next] media: stm32: dcmi: Remove redundant dev_err call

Hugues FRUCHET hugues.fruchet at foss.st.com
Mon Sep 26 00:33:10 PDT 2022


Hi Shang,

Thanks for the patch:

Acked-by: Hugues Fruchet <hugues.fruchet at foss.st.com>

BR,
Hugues.

On 9/23/22 12:07, Shang XiaoJing wrote:
> devm_ioremap_resource() prints error message in itself. Remove the
> dev_err call to avoid redundant error message.
> 
> Signed-off-by: Shang XiaoJing <shangxiaojing at huawei.com>
> ---
>   drivers/media/platform/st/stm32/stm32-dcmi.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/media/platform/st/stm32/stm32-dcmi.c b/drivers/media/platform/st/stm32/stm32-dcmi.c
> index 2ca95ab2b0fe..70e1b6af0448 100644
> --- a/drivers/media/platform/st/stm32/stm32-dcmi.c
> +++ b/drivers/media/platform/st/stm32/stm32-dcmi.c
> @@ -1997,10 +1997,8 @@ static int dcmi_probe(struct platform_device *pdev)
>   	}
>   
>   	dcmi->regs = devm_ioremap_resource(&pdev->dev, dcmi->res);
> -	if (IS_ERR(dcmi->regs)) {
> -		dev_err(&pdev->dev, "Could not map registers\n");
> +	if (IS_ERR(dcmi->regs))
>   		return PTR_ERR(dcmi->regs);
> -	}
>   
>   	mclk = devm_clk_get(&pdev->dev, "mclk");
>   	if (IS_ERR(mclk)) {



More information about the linux-arm-kernel mailing list