[PATCH v3 4/7] arm64/fpsimd: Stop using TIF_SVE to manage register saving in KVM

Mark Brown broonie at kernel.org
Tue Sep 20 11:53:01 PDT 2022


On Tue, Sep 20, 2022 at 07:04:24PM +0100, Marc Zyngier wrote:
> Mark Brown <broonie at kernel.org> wrote:

> > -	switch (last->to_save) {
> > -	case FP_STATE_TASK:
> > -		break;
> > -	case FP_STATE_FPSIMD:
> > -		WARN_ON_ONCE(save_sve_regs);
> > -		break;
> > -	case FP_STATE_SVE:
> > -		WARN_ON_ONCE(!save_sve_regs);
> > -		break;
> > -	}

> Given how short-lived this code is, consider dropping it altogether.
> Actually, the previous patch would make a lot more sense if it was
> merged with this one.

My thinking here is to introduce the state tracking and the
behaviour change separately to make it easier to unpick things if
anything goes wrong, it means that the behaviour change is in
clearly isolated patches separate to the more wide spread changes
to behaviour.  The early patches make it more explicit what we
are currently doing, the later ones do new things.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20220920/96da7aba/attachment-0001.sig>


More information about the linux-arm-kernel mailing list