[Patch v2 01/15] dt-bindings: media: s5p-mfc: Add new DT schema for MFC

[Aakarsh Jain]

> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski at linaro.org]
> Sent: 08 September 2022 20:41
> To: Aakarsh Jain <aakarsh.jain at samsung.com>; 'Krzysztof Kozlowski'
> <krzysztof.kozlowski at linaro.org>; 'Smitha T Murthy'
> <smitha.t at samsung.com>; linux-arm-kernel at lists.infradead.org; linux-
> media at vger.kernel.org; linux-kernel at vger.kernel.org;
> devicetree at vger.kernel.org
> Cc: m.szyprowski at samsung.com; andrzej.hajda at intel.com;
> mchehab at kernel.org; hverkuil-cisco at xs4all.nl;
> ezequiel at vanguardiasur.com.ar; jernej.skrabec at gmail.com;
> benjamin.gaignard at collabora.com; stanimir.varbanov at linaro.org;
> dillon.minfei at gmail.com; david.plowman at raspberrypi.com;
> mark.rutland at arm.com; robh+dt at kernel.org; krzk+dt at kernel.org;
> andi at etezian.org; alim.akhtar at samsung.com; aswani.reddy at samsung.com;
> pankaj.dubey at samsung.com; linux-fsd at tesla.com
> Subject: Re: [Patch v2 01/15] dt-bindings: media: s5p-mfc: Add new DT
> schema for MFC
> 
> On 08/09/2022 14:56, Aakarsh Jain wrote:
> >
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski at linaro.org]
> >> Sent: 07 September 2022 16:52
> >> To: Smitha T Murthy <smitha.t at samsung.com>; linux-arm-
> >> kernel at lists.infradead.org; linux-media at vger.kernel.org; linux-
> >> kernel at vger.kernel.org; devicetree at vger.kernel.org
> >> Cc: m.szyprowski at samsung.com; andrzej.hajda at intel.com;
> >> mchehab at kernel.org; hverkuil-cisco at xs4all.nl;
> >> ezequiel at vanguardiasur.com.ar; jernej.skrabec at gmail.com;
> >> benjamin.gaignard at collabora.com; stanimir.varbanov at linaro.org;
> >> dillon.minfei at gmail.com; david.plowman at raspberrypi.com;
> >> mark.rutland at arm.com; robh+dt at kernel.org; krzk+dt at kernel.org;
> >> andi at etezian.org; alim.akhtar at samsung.com;
> aswani.reddy at samsung.com;
> >> pankaj.dubey at samsung.com; linux-fsd at tesla.com;
> >> aakarsh.jain at samsung.com
> >> Subject: Re: [Patch v2 01/15] dt-bindings: media: s5p-mfc: Add new DT
> >> schema for MFC
> >>
> >> On 07/09/2022 08:47, Smitha T Murthy wrote:
> >>> Adds DT schema for s5p-mfc in yaml format
> >>
> >> s/Adds/Convert/
> >> (as convert to DT schema)
> >>
> > ok, I will change.
> >
> >> Please mention here changes to original binding (I see at least
> >> adding iommus and dropping some properties).
> >>
> > ok. I will make this changes.
> >>>
> >>> Signed-off-by: Aakarsh Jain <aakarsh.jain at samsung.com>
> >>> Signed-off-by: Smitha T Murthy <smitha.t at samsung.com>
> >>> ---
> >>>  .../devicetree/bindings/media/s5p-mfc.txt     |  77 +------------
> >>>  .../bindings/media/samsung,s5p-mfc.yaml       | 109
> >> ++++++++++++++++++
> >>>  2 files changed, 110 insertions(+), 76 deletions(-)  create mode
> >>> 100644 Documentation/devicetree/bindings/media/samsung,s5p-
> mfc.yaml
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/media/s5p-mfc.txt
> >>> b/Documentation/devicetree/bindings/media/s5p-mfc.txt
> >>> index aa54c8159d9f..0b7c4dd40095 100644
> >>> --- a/Documentation/devicetree/bindings/media/s5p-mfc.txt
> >>> +++ b/Documentation/devicetree/bindings/media/s5p-mfc.txt
> >>> @@ -1,76 +1 @@
> >>> -* Samsung Multi Format Codec (MFC)
> >>> -
> >>> -Multi Format Codec (MFC) is the IP present in Samsung SoCs which
> >>> -supports high resolution decoding and encoding functionalities.
> >>> -The MFC device driver is a v4l2 driver which can encode/decode
> >>> -video raw/elementary streams and has support for all popular -video
> codecs.
> >>> -
> >>> -Required properties:
> >>> -  - compatible : value should be either one among the following
> >>> -	(a) "samsung,mfc-v5" for MFC v5 present in Exynos4 SoCs
> >>> -	(b) "samsung,mfc-v6" for MFC v6 present in Exynos5 SoCs
> >>> -	(c) "samsung,mfc-v7" for MFC v7 present in Exynos5420 SoC
> >>> -	(d) "samsung,mfc-v8" for MFC v8 present in Exynos5800 SoC
> >>> -	(e) "samsung,exynos5433-mfc" for MFC v8 present in Exynos5433
> >> SoC
> >>> -	(f) "samsung,mfc-v10" for MFC v10 present in Exynos7880 SoC
> >>> -
> >>> -  - reg : Physical base address of the IP registers and length of memory
> >>> -	  mapped region.
> >>> -
> >>> -  - interrupts : MFC interrupt number to the CPU.
> >>> -  - clocks : from common clock binding: handle to mfc clock.
> >>> -  - clock-names : from common clock binding: must contain "mfc",
> >>> -		  corresponding to entry in the clocks property.
> >>> -
> >>> -Optional properties:
> >>> -  - power-domains : power-domain property defined with a phandle
> >>> -			   to respective power domain.
> >>> -  - memory-region : from reserved memory binding: phandles to two
> >> reserved
> >>> -	memory regions, first is for "left" mfc memory bus interfaces,
> >>> -	second if for the "right" mfc memory bus, used when no SYSMMU
> >>> -	support is available; used only by MFC v5 present in Exynos4 SoCs
> >>> -
> >>> -Obsolete properties:
> >>> -  - samsung,mfc-r, samsung,mfc-l : support removed, please use
> >>> memory-
> >> region
> >>> -	property instead
> >>
> >> When did they become obsolete? Is it enough of time to remove them?
> >
> > these properties were there earlier, we didn't added them in obsolete
> properties.
> 
> This is not the answer to my question. Is it enough of time to remove
> deprecated properties?
> 
sorry I misunderstood. These two mfc-l and mfc-r are still used in mfcv5 version as they use MFC_NUM_PORTS as 2, so we cannot make them obsolete yet. In next patch series we will add allOf: if: else: conditions for all the properties of each compatible string.
Thanks for the review.
> 
> 
> Best regards,
> Krzysztof