[EXT] Re: [PATCH v6 5/5] arm64: dts: freescale: add support for i.MX8DXL EVK board

[Krzysztof Kozlowski]

On 12/09/2022 16:35, Shenwei Wang wrote:

>>>>> +             gpio = <&pca6416_1 11 GPIO_ACTIVE_HIGH>;
>>>>
>>>> Missing enable-active-high?
>>>
>>> No. Enabling this regulator to select the fec1 interface instead of usdhc2.
>> Pulling this GPIO pin to low is to use FEC1 interface.
>>
>> Then the polarity cell should be GPIO_ACTIVE_LOW rather than
>> GPIO_ACTIVE_HIGH?
>>
> 
> That doesn't matter since any GPIO phandle flags are ignored in the node of "regulator-fixed".  The final flag is only determined by the property of "enable-active-high".  If there is a "enable-active-high", the GPIO line works as active high. If no such a property, it works as active low by default. Right?

No. Your flags must match hardware, even if bindings also expect
enable-active-high.


Best regards,
Krzysztof