[PATCH 1/2] ASoC: sunxi: sun4i-codec: silence misleading error in probe
Jernej Škrabec
jernej.skrabec at gmail.com
Mon Sep 12 09:14:44 PDT 2022
Dne nedelja, 11. september 2022 ob 16:57:11 CEST je Mikhail Rudenko
napisal(a):
> In the case when a codec device is probed before codec analog
> controls, snd_soc_register_card() returns -EPROBE_DEFER, resulting in
> a misleading error message
>
> sun4i-codec 1c22c00.codec: Failed to register our card
>
> even if the device is probed successfully later. Use dev_err_probe()
> to demote the above error to a debug message.
>
> Signed-off-by: Mikhail Rudenko <mike.rudenko at gmail.com>
Acked-by: Jernej Skrabec <jernej.skrabec at gmail.com>
Best regards,
Jernej
> ---
> sound/soc/sunxi/sun4i-codec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/sunxi/sun4i-codec.c b/sound/soc/sunxi/sun4i-codec.c
> index 60712f24ade5..01b461c64d68 100644
> --- a/sound/soc/sunxi/sun4i-codec.c
> +++ b/sound/soc/sunxi/sun4i-codec.c
> @@ -1825,7 +1825,7 @@ static int sun4i_codec_probe(struct platform_device
> *pdev)
>
> ret = snd_soc_register_card(card);
> if (ret) {
> - dev_err(&pdev->dev, "Failed to register our card\n");
> + dev_err_probe(&pdev->dev, ret, "Failed to register our
card\n");
> goto err_assert_reset;
> }
More information about the linux-arm-kernel
mailing list